Mixing
Issue uploading certain file types in Laravel
Issue uploading certain file types in Laravel
In my application, I have a TemplateController which has a bulk upload method within it. It works reasonably well but whenever I try to upload .eps files Laravel returns a validation error.
TemplateController
.eps
The files.0 must be a file of type: jpg, jpeg, png, gif, ai, eps, mp3,
ogg, mpga, mp4, mpeg, doc, docx, dotx, pdf, odt, xls, xlsm, xlsx, ppt,
pptx, vsd.
My issue is, I can see eps in the list of file extensions the validator is expecting.
eps
Here is the TemplateController
TemplateController
<?php
namespace AppHttpControllersEditable;
use AppFileMetaData;
use IlluminateHttpRequest;
use IlluminateSupportFacadesStorage;
use AppHttpControllersController;
class TemplateController extends Controller
{
/**
* Instantiate a new controller instance.
*
* @return void
*/
public function __construct()
{
$this->middleware(['role:Template Manager']);
}
/**
* Set allowed extensions for each file category
* This can be appended to as necessary as it's somewhat restrictive
*/
private $image_ext = [
'jpg', 'jpeg', 'png', 'gif',
'ai', 'eps'
];
private $audio_ext = [
'mp3', 'ogg', 'mpga'
];
private $video_ext = [
'mp4', 'mpeg'
];
private $document_ext = [
'doc', 'docx', 'dotx', 'pdf', 'odt',
'xls', 'xlsm', 'xlsx',
'ppt', 'pptx',
'vsd'
];
/**
* Display a listing of the resource.
*
* @return IlluminateHttpResponse
*/
public function index()
{
$files = FileMetaData::orderBy('category', 'DESC')->get();
return view('editable.templates-and-tools.index', compact('files'));
}
/**
* Show the form for creating a new resource.
*
* @return IlluminateHttpResponse
*/
public function create()
{
return view('editable.templates-and-tools.create');
}
/**
* Store a newly created resource in storage.
*
* @param IlluminateHttpRequest $request
* @return IlluminateHttpResponse
*/
public function store(Request $request)
{
// Get every extension that we allowed
$all_ext = implode(',', $this->allExtensions());
$this->validate($request, [
'name'=>'required|unique:file_meta_data|min:3|max:40',
'file' => 'required|file|mimes:' . $all_ext . '|max:50000'
]);
// Grab data from the request to fill the necessary fields
$name = $request->get('name');
$department = $request->get('department');
$category = $request->get('category');
$uploadedFile = $request->file('file');
// Get the extension and then use this to work out the file type
$size = $uploadedFile->getSize();
$extension = strtolower($file->getClientOriginalExtension());
$type = $this->getType($extension);
// Create a new instancce of this model
$file = new FileMetaData();
$file->name = $name;
$file->department = $department;
$file->category = $category;
$file->size = $size;
$file->type = $type;
$file->extension = $extension;
// Upload all the given files to Storage, within a specific directory
if ($department != '') {
$path = $uploadedFile->storeAs('library/' . $department, $name.'.'.$extension);
$category = null;
} elseif ($category != '') {
$path = $uploadedFile->storeAs('library/' . $category, $name.'.'.$extension);
$department = null;
}
// Grab the filepath so we can store it in the database
$file->filepath = $path;
// Finally, check that the file exists and save the model
if (Storage::exists($path)) {
$file->save();
return redirect('editable/templates-and-tools')->with('success', $file->name . 'has been added');
}
}
/**
* Show the form to edit this resource
*/
public function edit($id)
{
$file = FileMetaData::find($id);
return view('editable.templates-and-tools.edit', compact('file'));
}
/**
* Update the specified resource in storage.
*
* @param IlluminateHttpRequest $request
* @param int $id
* @return IlluminateHttpResponse
*/
public function update(Request $request, $id)
{
// Get every extension that we allowed
$all_ext = implode(',', $this->allExtensions());
$this->validate($request, [
'name'=>'required|unique:file_meta_data|min:3|max:40',
]);
$file = FileMetaData::find($id);
// Get the current path to this file
$currentPath = Storage::url($file->name . '.' . $file->extension);
$extension = pathinfo($currentPath, PATHINFO_EXTENSION);
// Grab data from the request to fill the necessary fields
$name = $request->get('name');
$department = $request->get('department');
$category = $request->get('category');
// Upload all the given files to Storage, within a specific directory
if ($department != '') {
$newPath = 'library/' . $department . '/' . $name.'.'.$extension;
Storage::move($file->filepath, $newPath);
$category = null;
} elseif ($category != '') {
$newPath = 'library/' . $category . '/' . $name.'.'.$extension;
Storage::move($file->filepath, $newPath);
$department = null;
}
// Grab the filepath so we can store it in the database
$file->filepath = $newPath;
$file->name = $name.'.'.$extension;
$file->department = $department;
$file->category = $category;
$file->save();
return redirect('editable/templates-and-tools')->with('success', $file->name . 'has been edited successfully');
}
/**
* Remove the specified resource from storage.
*
* @param int $id
* @return IlluminateHttpResponse
*/
public function destroy($id)
{
$file = FileMetaData::find($id);
if (Storage::delete($file->filepath)) {
$file->delete();
}
return redirect('editable/templates-and-tools')->with('success', $file->name . ' has been deleted');
}
/**
* Show page containing bulk upload form
*
* @return void
*/
public function addBulk()
{
return view('editable.templates-and-tools.bulk');
}
/**
* Process uploading of multiple files
*
* @param Request $request
* @return void
*/
public function bulkUpload(Request $request)
{
// Get every extension that we allowed
$all_ext = implode(',', $this->allExtensions());
$this->validate($request, [
'files.*' => 'required|file|mimes:' . $all_ext . '|max:50000'
]);
// Initialize a file upload counter
$fileCount = 0;
// Get the category and department from the form
$department = $request->get('department');
$category = $request->get('category');
// Ensure that the request contains files
if ($request->hasfile('files')) {
// Loop through each file and add it to storage
foreach ($request->file('files') as $file) {
// Get the meta data for each file
$name = $file->getClientOriginalName();
$extension = strtolower($file->getClientOriginalExtension());
$type = $this->getType($extension);
$size = $file->getSize();
// Upload all the given files to Storage, within a specific directory
if ($department != '') {
$path = $file->storeAs('library/' . $department, $name);
$category = null;
} elseif ($category != '') {
$path = $file->storeAs('library/' . $category, $name);
$department = null;
}
// Grab the filepath so we can store it in the database
$file->filepath = $path;
// Create the database entries for the newly uploaded files
FileMetaData::firstOrCreate([
'name' => $name,
'department' => $department,
'category' => $category,
'type' => $type,
'extension' => $extension,
'size' => $size,
'filepath' => $path
]);
$fileCount++;
}
return redirect('editable/templates-and-tools')->with('success', $fileCount . ' files have been added');
}
}
/**
* Get the file type based on the given extension
* This could be used to categorise files by more generic types
*
* @param string $ext Specific extension
* @return string Type
*/
private function getType($ext)
{
if (in_array($ext, $this->image_ext)) {
return 'image';
}
if (in_array($ext, $this->audio_ext)) {
return 'audio';
}
if (in_array($ext, $this->video_ext)) {
return 'video';
}
if (in_array($ext, $this->document_ext)) {
return 'document';
}
}
/**
* Get all extensions by merging the individual arrays together
* If any are added above remember to add them here
*
* @return array Extensions of all file types
*/
private function allExtensions()
{
return array_merge($this->image_ext, $this->audio_ext, $this->video_ext, $this->document_ext);
}
}
I have also performed a dump and die of the $extension variable on a single eps file and it does indeed return eps.
$extension
In order to get to this example I had to remove my validation:
$this->validate($request, [
'files.*' => 'required|file|mimes:' . $all_ext . '|max:50000'
]);
Reduced Snippet
foreach ($request->file('files') as $file) {
// Get the meta data for each file
$name = $file->getClientOriginalName();
$extension = strtolower($file->getClientOriginalExtension());
$type = $this->getType($extension);
$size = $file->getSize();
dd($extension);
}
When I attempted to upload the same file the browser output was as below:
"eps"
As the script died at getting the extension, anyway, this clearly says eps
Is there something different about eps files or am I being dense?
I've literally tested every other extension in my list of allowed extensions, which again, are the following:
/**
* Set allowed extensions for each file category
* This can be appended to as necessary as it's somewhat restrictive
*/
private $image_ext = [
'jpg', 'jpeg', 'png', 'gif',
'ai', 'eps'
];
private $audio_ext = [
'mp3', 'ogg', 'mpga'
];
private $video_ext = [
'mp4', 'mpeg'
];
private $document_ext = [
'doc', 'docx', 'dotx', 'pdf', 'odt',
'xls', 'xlsm', 'xlsx',
'ppt', 'pptx',
'vsd'
];
Just to clarify, files is an array of uploaded files and the HTML for it is:
files
<input type='file' name='files' multiple required />
File in question
eps
eps
I'm confident it is a real eps, I'll update my question to show the file.
– Jesse Orange
2 days ago
I'm going to add a screenshot from Windows File Explorer, as well as the File Properties
– Jesse Orange
2 days ago
Mate no need just making sure the mimetype is ok :)
– Kyslik
2 days ago
Could you actually make a dummy eps file that we can use and test things up? I fear that the problem is with MimeType guesser (symphony).
– Kyslik
2 days ago
By clicking "Post Your Answer", you acknowledge that you have read our updated terms of service, privacy policy and cookie policy, and that your continued use of the website is subject to these policies.
Is it a real
epsfile or just random file renamed toeps?– Kyslik
2 days ago