android studio :Attempt to invoke virtual method on a null object reference


android studio :Attempt to invoke virtual method on a null object reference



can someone help me? whenever i click on the dialoginterface.onclicklistener button the app just crashes can anyone check for me my codes . ALso when i want the same dialoginterface button to retrieve the inserted data from database to be viewed as a list view ill provide with database and page codes




public class mainscreen extends AppCompatActivity {
private static final String TAG = "ListDataActivity";
ImageButton add;
DatabaseHelper db;
private ListView listView;

@Override
protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setContentView(R.layout.activity_mainscreen);

listView = (ListView)findViewById(R.id.listview);

add = (ImageButton) findViewById(R.id.addbtn);
//populateListView();

add.setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View v) {
final AlertDialog.Builder builder = new AlertDialog.Builder(mainscreen.this);
View mView = getLayoutInflater().inflate(R.layout.promptexercise,null);
final EditText addexerText = (EditText)mView.findViewById(R.id.editText2);
Button cancel = (Button) mView.findViewById(R.id.button4);
Button ok = (Button) mView.findViewById(R.id.button3);
ok.setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View v) {
String newEntry = addexerText.getText().toString();
if (addexerText.length() != 0) {
AddExerData(newEntry);
addexerText.setText("");
}else{
toastMessage("You must enter an exercise name in the field!");
}
Toast.makeText(mainscreen.this, newEntry, Toast.LENGTH_SHORT).show();

}
});



builder.setView(mView);
AlertDialog dialog = builder.create();
dialog.show();
dialog.create();




}
});




}
//----- method to add data into database
public void AddExerData(String newEntry){
boolean insertData = db.addexerData(newEntry);
if(insertData){
toastMessage("Data Successfully Inserted");
}else{
toastMessage("Something went wrong");
}

}


// private void populateListView(){
// Log.d(TAG,"populateListView:Displaying data in the ListView");
//get the data and append to a list
// Cursor data = db.getData();
// //ArrayList<String>listData = new ArrayList<>();
// while(data.moveToNext()){
//get the value from the database from col 1 -id
//then add it into arraylist
// listData.add(data.getString(1));
// }
// ListAdapter adapter = new ArrayAdapter<>(this,android.R.layout.simple_list_item_1,listData);
// listView.setAdapter(adapter);
// }


//method to make the msg pop
private void toastMessage(String message){
Toast.makeText(this,message,Toast.LENGTH_SHORT).show();
}

}




LOGCAT

Process: com.example.hibatulhadi.trackerapp2, PID: 643
java.lang.NullPointerException: Attempt to invoke virtual method 'boolean com.example.hibatulhadi.trackerapp2.DatabaseHelper.addexerData(java.lang.String)' on a null object reference
at com.example.hibatulhadi.trackerapp2.mainscreen.AddExerData(mainscreen.java:79)
at com.example.hibatulhadi.trackerapp2.mainscreen$1$1.onClick(mainscreen.java:50)
at android.view.View.performClick(View.java:6294)
at android.view.View$PerformClick.run(View.java:24770)
at android.os.Handler.handleCallback(Handler.java:790)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:164)
at android.app.ActivityThread.main(ActivityThread.java:6494)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)





please post the logcat! and yes I can see the error in the code that is causing the crash! but there can be one more cause too! so please provide the logcat of your error
– Rizwan atta
Jun 29 at 16:55





what's the error you are getting in stack trace..
– pop
Jun 29 at 16:57





final EditText e1 = (EditText) promptView.findViewById(R.id.editText); you need to change your edittext initialization as mentioned above
– pop
Jun 29 at 17:00





@rizwanatta i poted the logcat and tried ur suggestions. the app still crashes. any help?
– Lonely Bat
Jun 30 at 1:36





@LonelyBat check the answer edit! I edited the answer that will help! you are not initialising the db! see the answer and follow it
– Rizwan atta
2 days ago




1 Answer
1



In you button's clickListener you are Inflating a second layout to show up in the dialogbox which seems to have an edit text in it which is being registered after the loading dialog creation which can be the simple cause here as you are using findviewbyid generically you should specify the inflated view's name and its findViewbyid! simply put your clicklistener code should look like this!


add.setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View v) {
LayoutInflater layoutInflater = LayoutInflater.from(mainscreen.this);
View promptView = layoutInflater.inflate(R.layout.promptexercise, null);
AlertDialog.Builder alertdialog = new AlertDialog.Builder(mainscreen.this);
alertdialog.setView(promptView);
// here use findviewby id from your inflated view like this!
final EditText e1 = (EditText) promptView.findViewById(R.id.editText);
alertdialog.setCancelable(false)
.setPositiveButton("OK", new DialogInterface.OnClickListener() {
@Override
public void onClick(DialogInterface dialog, int which) {

String newEntry9 = e1.getText().toString();
if (e1.length() != 0) {
AddExerData(newEntry9);
e1.setText("");
} else {
toastMessage("You must enter an exercise name in the field!");
}
Toast.makeText(mainscreen.this), newEntry9, Toast.LENGTH_SHORT).show();


}

})
.setNegativeButton("Cancel", new DialogInterface.OnClickListener() {
@Override
public void onClick(DialogInterface dialog, int which) {
dialog.cancel();
}
});
alertdialog.create();
alertdialog.show();

}
});



2nd Missing thing



In your write data method the db is not initialised ! that is the error causing the crash! you have to initialise it before using it!


//----- method to add data into database
public void AddExerData(String newEntry){
// this db variable you are using! is not initialised!
boolean insertData = db.addexerData(newEntry);
if(insertData){
toastMessage("Data Successfully Inserted");
}else{
toastMessage("Something went wrong");
}

}



Maybe this could SOLVE it like this if this is SQLITE database


//----- SOLUTION method to add data into database
public void AddExerData(String newEntry){
// if you have a field (class level variable) SqliteDatabase db;
db = new YourDBHelperClass().getWriteabledatabase();
boolean insertData = db.addexerData(newEntry);
if(insertData){
toastMessage("Data Successfully Inserted");
}else{
toastMessage("Something went wrong");
}

}





hey there i tried it but it still wont work. can we talk somewhere?
– Lonely Bat
2 days ago





i didnt declare my databasehelper LOL. thank you so much
– Lonely Bat
2 days ago






By clicking "Post Your Answer", you acknowledge that you have read our updated terms of service, privacy policy and cookie policy, and that your continued use of the website is subject to these policies.

Comments

Post a Comment

Popular posts from this blog

paramiko-expect timeout is happening after executing the command

paramiko-expect timeout is happening after executing the command Can someone help me why timeout is happening after executing the command .I am trying to SSH to a machine and execute a command.I want to store the result of the executed command . I have referred paramiko-timeout but i didn't get my expected result. import traceback try: import paramiko except ImportError: raise Exception("Please install paramiko , pip install paramiko") import pexpect from paramiko_expect import SSHClientInteraction def main(): HOSTNAME = "minion5.net" USERNAME = "root" PASSWORD = "help@432" PROMPT = "root@*:~$s+" try: client = paramiko.SSHClient() client.load_system_host_keys() client.set_missing_host_key_policy(paramiko.AutoAddPolicy()) client.connect(hostname=HOSTNAME, username=USERNAME, password=PASSWORD) with SSHClientInteraction(client, timeout=20, display=True) as interact: ...
Read more

Opening a url is failing in Swift

Opening a url is failing in Swift breakpointing inside the callback and logging success shows false. I added itms-apps to my plist: LSApplicationQueriesSchemes and put this in my app delegate: func application(_ app: UIApplication, open url: URL, options: [UIApplicationOpenURLOptionsKey : Any] = [:]) -> Bool { return true } func moreTapped() { let url = NSURL(string: "itms-apps://itunes.com/developer/quantum-productions/id979315877") if #available(iOS 10.0, *) { UIApplication.shared.open(url! as URL, options: [:], completionHandler: {(success: Bool) in }) } else { UIApplication.shared.openURL(url! as URL) } } Are you testing on a real device? – rmaddy Jun 21 at 23:57 I try on a device, get "Cannot Connect to App Store". Device is online ...
Read more

Export result set on Dbeaver to CSV

Export result set on Dbeaver to CSV Normally I use Dbeaver for windows and always export my result set like this: run my query --> select the result --> export the result set --> select export to clipboard --> done This step by step puts my result set in my clipboard and I can paste it wherever I want to work with it. The problem is that now I am using dbeaver for mac and this guide is not working. I can go on until the moment that I select my result set like in the image below: exporting data set But once I go further in the process, in the last step I get: no query Note that in "source" it was suppose to show the query that originated the result set, but instead it says just "select. As a result it does't select my result or anything (besides being "successful"). Normally my query would show up there automatically and I couldn't find any option that corrects this problem in the menus. Please help me! Thanks. Aft...
Read more