Posts

Showing posts with the label refactoring

How to improve code and reduce number of code?

How to improve code and reduce number of code? That code is exactly the same, so I want to refactor it in a simple way to reduce the number of lines. One thing which is different is min/max function execution. Is it available pointer to function in python to call min/max as a pointer to function like in C? def calculate_min(a, b, c, d, e, f): try: v = a[e][f] b[d] = v if np.isnan(b[d]) else min(b[d], v) #min() except KeyError as exc: logger.error("keyerror") def calculate_max(a, b, c, d, e, f): try: v = a[e][f] b[d] = v if np.isnan(b[d]) else max(b[d], v) #max() except KeyError as exc: logger.error("keyerror") Totally unrelated but you should use logger.exception() instead of logger.error() => this will add the full error message and traceback to the log, which is very useful for debugging. – bruno desthuilliers Jun 29 at 9:06 ...