Checking VBScript for syntax error


Checking VBScript for syntax error



I have a simple VBScript that copies a few files and calls a custom executable from the copied files on the system to set up a scheduled task. I am not well versed in VBScript and getting an error during compilation. It says "Expected end of statement".



Here is my script. PLease help me get rid of that compilation error.


Set objFso = CreateObject("Scripting.FileSystemObject")
Set wshshell = CreateObject("WScript.Shell")

Const HKEY_CURRENT_USER = &H80000001
Const HKEY_LOCAL_MACHINE = &H80000002

strComputer = "."
ScriptPath = objfso.GetParentFolderName(WScript.ScriptFullName)
WinDir = WshShell.ExpandEnvironmentStrings("%WinDir%")
Set objRegistry = GetObject("winmgmts:" & strComputer &
"rootdefault:StdRegProv")
Set XMLDOM = CreateObject("Microsoft.XMLDOM")
XMLDOM.Async = False
logfile = WinDir & "CDFLogsJoinDom.log"
If
WScript.Arguments.Named.Exists("elevated") = False

Then
'Launch the script again as administrator
CreateObject("Shell.Application").ShellExecute "wscript.exe", """" &
WScript.ScriptFullName & """ /elevated", "", "runas", 1
WScript.Quit
Else
Set LogF = objfso.CreateTextFile(logfile)
End If
If Right(ScriptPath, 1) <> "" Then
ScriptPath = ScriptPath & ""
logF.WriteLine ("******************Script is running from " & ScriptPath)
End If

JoinDomOffline

Sub JoinDomOffline
objFso.CopyFile ScriptPath & "FilesJoinDomain.exe", "C:Windows"
objFso.CopyFile ScriptPath &
"FilesJoinDomain.xml","C:WindowsSystem32Tasks"
wshshell.Run cmd.exe /c schtasks /Create /TN "JoinDomain" /XML
"C:WindowsSystem32TasksJoinDOmain.xml"
End Sub
WScript.Quit





Learn to properly indent your code, and you'll be able to figure these sorts of problems out for yourself.
– Ken White
Jun 29 at 22:57





I see 3 major issues with your code. a) The Else is missing an End If. b) If you want to continue a statement in the next line you MUST put an underscore at the end of the line. Ending a line with the concatenation operator is NOT sufficient. c) The quoting in your wshshell.Run line is broken.
– Ansgar Wiechers
Jun 29 at 23:13



Else


End If


wshshell.Run





Edited based on the above comments..still does not seem to resolve
– Alcox
Jun 29 at 23:45





can you post the correct script here...i am sure it would take long for experienced guys like you
– Alcox
Jun 29 at 23:46





You're clearly not listening. You have a glaring, very clear missing End after your edit. Are you reading the code? And your indentation is still wrong. Outdent the Sub JoinDomOffLine and it's code to the margin. See the large hole in the middle between the Else and that new Sub location? Figure out what's missing in that area.
– Ken White
Jun 29 at 23:53



End


Sub JoinDomOffLine


Else


Sub




1 Answer
1



You are missing an End statement. Every IF / ELSE / END block needs to be closed. A quick scan of the script and I am assuming it is after the Set LogF = objfso.CreateTextFile(logfile) statement.
Editors like Notepad++ or Visual Studio highlight these problems. It is easy to miss them in a text editor with code that is not indented.





can you post the correct script here...i am sure it would take long for experienced guys like you
– Alcox
Jun 29 at 23:46






By clicking "Post Your Answer", you acknowledge that you have read our updated terms of service, privacy policy and cookie policy, and that your continued use of the website is subject to these policies.

Comments

Post a Comment

Popular posts from this blog

paramiko-expect timeout is happening after executing the command

paramiko-expect timeout is happening after executing the command Can someone help me why timeout is happening after executing the command .I am trying to SSH to a machine and execute a command.I want to store the result of the executed command . I have referred paramiko-timeout but i didn't get my expected result. import traceback try: import paramiko except ImportError: raise Exception("Please install paramiko , pip install paramiko") import pexpect from paramiko_expect import SSHClientInteraction def main(): HOSTNAME = "minion5.net" USERNAME = "root" PASSWORD = "help@432" PROMPT = "root@*:~$s+" try: client = paramiko.SSHClient() client.load_system_host_keys() client.set_missing_host_key_policy(paramiko.AutoAddPolicy()) client.connect(hostname=HOSTNAME, username=USERNAME, password=PASSWORD) with SSHClientInteraction(client, timeout=20, display=True) as interact: ...
Read more

Export result set on Dbeaver to CSV

Export result set on Dbeaver to CSV Normally I use Dbeaver for windows and always export my result set like this: run my query --> select the result --> export the result set --> select export to clipboard --> done This step by step puts my result set in my clipboard and I can paste it wherever I want to work with it. The problem is that now I am using dbeaver for mac and this guide is not working. I can go on until the moment that I select my result set like in the image below: exporting data set But once I go further in the process, in the last step I get: no query Note that in "source" it was suppose to show the query that originated the result set, but instead it says just "select. As a result it does't select my result or anything (besides being "successful"). Normally my query would show up there automatically and I couldn't find any option that corrects this problem in the menus. Please help me! Thanks. Aft...
Read more

Opening a url is failing in Swift

Opening a url is failing in Swift breakpointing inside the callback and logging success shows false. I added itms-apps to my plist: LSApplicationQueriesSchemes and put this in my app delegate: func application(_ app: UIApplication, open url: URL, options: [UIApplicationOpenURLOptionsKey : Any] = [:]) -> Bool { return true } func moreTapped() { let url = NSURL(string: "itms-apps://itunes.com/developer/quantum-productions/id979315877") if #available(iOS 10.0, *) { UIApplication.shared.open(url! as URL, options: [:], completionHandler: {(success: Bool) in }) } else { UIApplication.shared.openURL(url! as URL) } } Are you testing on a real device? – rmaddy Jun 21 at 23:57 I try on a device, get "Cannot Connect to App Store". Device is online ...
Read more