Download favicon from url returns broken .ico files


Download favicon from url returns broken .ico files



I tried to create a script to download favicons from a list of links:



My file link_list.txt looks like the following:


link_list.txt


http://stackoverflow.com
http://google.com
facebook.com



I am using the following library to check and download favicons:



Github: FaviconDownloader



My script currently looks like the following:


<?php
require_once 'vendor/autoload.php';
use VincepareFaviconDownloaderFaviconDownloader;

$fh = fopen(dirname(__FILE__).DIRECTORY_SEPARATOR . 'link_list.txt','r');
while ($line = fgets($fh)) {

//if the url has not http:// add it
if(preg_match("@^http://@i",$line))
$line = preg_replace("@(http://)+@i",'http://',$line);
else
$line = 'http://'.$line;
echo('URL: ' . $line."n");
$favicon = new FaviconDownloader($line);

if (!$favicon->icoExists) {
echo "No favicon for ".$favicon->url;
}

// get name of url
$parts = parse_url($line);
$path_parts = explode('.', isset($parts['host'])?$parts['host']:$parts['path']);

echo 'Filename: fav-'. $path_parts[0] .'.ico' . "n";
$filename = dirname(__FILE__).DIRECTORY_SEPARATOR.'fav-'. $path_parts[0] . '.ico';
file_put_contents($filename, $favicon->icoData);
echo "Saved to ".$filename."nn";
}

fclose($fh);



When I run my script I only get to download the favicon of facebook, the other favicons - stackoverflow and google - are broken:



enter image description here



Any suggestions what is wrong with my script?



I appreciate your replies!





How are they broken? Have you looked inside the files? Maybe they contain error message. What HTTP status and MIME type did the response have?
– lxg
Jun 29 at 11:47





@lxg Please see the image that I added above. The saved files look like this.
– Anna.Klee
Jun 29 at 11:55





@Anna.Klee find the file on your filesystem, right-click it and open it with plain text editor such as notepad or gedit. It might contain error messages instead of image data.
– ino
Jun 29 at 12:15





@ino I tested the code above now even more and I found that only the last favicon gets downloaded. Any suggestions why this is happening?
– Anna.Klee
yesterday










By clicking "Post Your Answer", you acknowledge that you have read our updated terms of service, privacy policy and cookie policy, and that your continued use of the website is subject to these policies.

Comments

Post a Comment

Popular posts from this blog

paramiko-expect timeout is happening after executing the command

paramiko-expect timeout is happening after executing the command Can someone help me why timeout is happening after executing the command .I am trying to SSH to a machine and execute a command.I want to store the result of the executed command . I have referred paramiko-timeout but i didn't get my expected result. import traceback try: import paramiko except ImportError: raise Exception("Please install paramiko , pip install paramiko") import pexpect from paramiko_expect import SSHClientInteraction def main(): HOSTNAME = "minion5.net" USERNAME = "root" PASSWORD = "help@432" PROMPT = "root@*:~$s+" try: client = paramiko.SSHClient() client.load_system_host_keys() client.set_missing_host_key_policy(paramiko.AutoAddPolicy()) client.connect(hostname=HOSTNAME, username=USERNAME, password=PASSWORD) with SSHClientInteraction(client, timeout=20, display=True) as interact: ...
Read more

Opening a url is failing in Swift

Opening a url is failing in Swift breakpointing inside the callback and logging success shows false. I added itms-apps to my plist: LSApplicationQueriesSchemes and put this in my app delegate: func application(_ app: UIApplication, open url: URL, options: [UIApplicationOpenURLOptionsKey : Any] = [:]) -> Bool { return true } func moreTapped() { let url = NSURL(string: "itms-apps://itunes.com/developer/quantum-productions/id979315877") if #available(iOS 10.0, *) { UIApplication.shared.open(url! as URL, options: [:], completionHandler: {(success: Bool) in }) } else { UIApplication.shared.openURL(url! as URL) } } Are you testing on a real device? – rmaddy Jun 21 at 23:57 I try on a device, get "Cannot Connect to App Store". Device is online ...
Read more

Export result set on Dbeaver to CSV

Export result set on Dbeaver to CSV Normally I use Dbeaver for windows and always export my result set like this: run my query --> select the result --> export the result set --> select export to clipboard --> done This step by step puts my result set in my clipboard and I can paste it wherever I want to work with it. The problem is that now I am using dbeaver for mac and this guide is not working. I can go on until the moment that I select my result set like in the image below: exporting data set But once I go further in the process, in the last step I get: no query Note that in "source" it was suppose to show the query that originated the result set, but instead it says just "select. As a result it does't select my result or anything (besides being "successful"). Normally my query would show up there automatically and I couldn't find any option that corrects this problem in the menus. Please help me! Thanks. Aft...
Read more